GtkLabel: Prefix more ui parser errors
authorMatthias Clasen <mclasen@redhat.com>
Mon, 27 Apr 2015 23:20:29 +0000 (19:20 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 27 Apr 2015 23:20:29 +0000 (19:20 -0400)
This may become useful in gnome-builder for highlighting errors,
so do it consistently.

gtk/gtklabel.c

index e51300379e706d3b7f4e5a4ca1886e768a1afb3a..def986faebcc4ed5e622a07c8f5b8caa45cfd2fe 100644 (file)
@@ -1598,17 +1598,19 @@ pango_start_element (GMarkupParseContext *context,
         }
 
       attr = attribute_from_text (data->builder, name, value, error);
-
-      if (attr)
+      if (!attr)
         {
-          attr->start_index = start_val;
-          attr->end_index = end_val;
+          _gtk_builder_prefix_error (data->builder, context, error);
+          return;
+        }
 
-          if (!data->attrs)
-            data->attrs = pango_attr_list_new ();
+      attr->start_index = start_val;
+      attr->end_index = end_val;
 
-          pango_attr_list_insert (data->attrs, attr);
-        }
+      if (!data->attrs)
+        data->attrs = pango_attr_list_new ();
+
+      pango_attr_list_insert (data->attrs, attr);
     }
   else if (strcmp (element_name, "attributes") == 0)
     {